-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard Navigation #3193
base: master
Are you sure you want to change the base?
Keyboard Navigation #3193
Conversation
Can one of the admins verify this patch? |
@@ -655,15 +655,15 @@ public interface OdeMessages extends Messages, AutogeneratedOdeMessages { | |||
@Description("Message providing details about starting a USB connection.") | |||
String usbMenuItem(); | |||
|
|||
@DefaultMessage("Reset Connection") | |||
@DefaultMessage("Reset Connection (Alt + Shift + R)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to revisit this choice, since Alt on Windows typically maps to Cmd on macOS, and Cmd + R will refresh the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to revisit this choice, since Alt on Windows typically maps to Cmd on macOS, and Cmd + R will refresh the page.
Does't Ctrl usually map to Cmd on MacOS in GUI aps? I usually expect Alt to map to Option.
I realize that we have a Ctrl button, and that works as Ctrl for a lot of command line stuff. There's no consistent official mapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback @ewpatton. I will look into these and fix them.
I will once go through the shortcuts in macOS and see for any more overlaps.
I still need to add code that adjusts the shortcut key messages based on whether the user is on Windows or macOS.
The community feedback is still pending, and I plan to complete it by the end of this week.
appinventor/appengine/src/com/google/appinventor/client/editor/youngandroid/DesignToolbar.java
Show resolved
Hide resolved
...ne/src/com/google/appinventor/client/editor/youngandroid/actions/RefreshCompanionAction.java
Outdated
Show resolved
Hide resolved
...tor/appengine/src/com/google/appinventor/client/editor/youngandroid/actions/ResetAction.java
Outdated
Show resolved
Hide resolved
.../src/com/google/appinventor/client/editor/youngandroid/palette/YoungAndroidPalettePanel.java
Outdated
Show resolved
Hide resolved
.../src/com/google/appinventor/client/editor/youngandroid/palette/YoungAndroidPalettePanel.java
Outdated
Show resolved
Hide resolved
.../src/com/google/appinventor/client/editor/youngandroid/palette/YoungAndroidPalettePanel.java
Show resolved
Hide resolved
.../src/com/google/appinventor/client/editor/youngandroid/palette/YoungAndroidPalettePanel.java
Outdated
Show resolved
Hide resolved
appinventor/appengine/src/com/google/appinventor/client/explorer/SourceStructureExplorer.java
Show resolved
Hide resolved
Issues from testing Sep 4, using Mac Firefox:
|
This PR improves the keyboard accessibility of the App Inventor by introducing the following features:
Keyboard Shortcuts